Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: remove patch in apply to make it standalone action #134

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

FogDong
Copy link
Member

@FogDong FogDong commented Feb 15, 2023

Description of your changes

remove patch in apply to make it standalone action

I have:

  • Read and followed KubeVela's contribution process.
  • Related Docs updated properly. In a new feature or configuration option, an update to the documentation is necessary.
  • Run make reviewable to ensure this PR is ready for review.
  • Added backport release-x.y labels to auto-backport this PR if necessary.

How has this code been tested

Special notes for your reviewer

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Base: 68.12% // Head: 67.97% // Decreases project coverage by -0.16% ⚠️

Coverage data is based on head (73f3b67) compared to base (92d7b6a).
Patch coverage: 51.35% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   68.12%   67.97%   -0.16%     
==========================================
  Files          48       48              
  Lines        4311     4334      +23     
==========================================
+ Hits         2937     2946       +9     
- Misses       1015     1022       +7     
- Partials      359      366       +7     
Flag Coverage Δ
e2etests 25.06% <2.70%> (-0.13%) ⬇️
unit-test 64.92% <48.64%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/providers/kube/handle.go 56.90% <51.35%> (-2.59%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@FogDong FogDong merged commit edc7849 into kubevela:main Feb 15, 2023
@github-actions
Copy link

Backport failed for release-0.4, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin release-0.4
git worktree add -d .worktree/backport-134-to-release-0.4 origin/release-0.4
cd .worktree/backport-134-to-release-0.4
git checkout -b backport-134-to-release-0.4
ancref=$(git merge-base 92d7b6a260131fb7593d3ab6a93979d9ca62b14f 73f3b67a20ffa0b162c0c22e79a1178dfcdf6aae)
git cherry-pick -x $ancref..73f3b67a20ffa0b162c0c22e79a1178dfcdf6aae

FogDong added a commit to FogDong/workflow that referenced this pull request Feb 15, 2023
Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
FogDong added a commit that referenced this pull request Feb 15, 2023
…e version (#135)

* Fix: remove patch in apply to make it standalone action (#134)

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

* update cue version

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>

---------

Signed-off-by: FogDong <dongtianxin.tx@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants